update preflight.yml to be better

preflight.yml

@@ -4,9 +4,13 @@
   become: true
   gather_facts: true
 
-
   vars:
-    __part_size: 20GB
+    __vg_name   : test-vg
+    __lv_name   : test-lv
+    __lv_size   : 18g
+    __lv_mount  : "/data/{{ __lv_name }}"
+    __lv_fstype : ext4
+    __part_size : 20GB
     __partition_devices:
       - /dev/vdb
       - /dev/vdc
@@ -39,13 +43,6 @@
       - /dev/sdo
       - /dev/sdp
 
-    __vg_name   : test-vg
-    __lv_name   : test-lv
-    __lv_size   : 18g
-    __lv_mount  : "/data/{{ __lv_name }}"
-    __lv_fstype : ext4
-
-
   tasks:
     - name: Debug __partition_devices
       ansible.builtin.debug:
@@ -56,68 +53,13 @@
                 map('regex_replace', '(?P<device>sd.*)', '\\g<device>' + '1', multiline=True) }}"
         verbosity: 1
 
-
     - name: Install LVM2
       ansible.builtin.package:
         name  : lvm2
         state : present
 
-
+    - name: Include LVM setup creation tasks
-    - name: Debug __partition_devices
+      ansible.builtin.include_tasks: tasks/create_lvm_setup.yml
-      ansible.builtin.debug:
-        msg: "{{ item }}1 :: {{ item | split('/') | last }}"
-        verbosity: 1
       loop: "{{ __partition_devices }}"
 
-
-    - name: Create partitions on all drives
-      community.general.parted:
-        device   : "{{ item }}"
-        number   : 1
-        flags    : ['lvm']
-        state    : present
-        part_end : "{{ __part_size }}"
-      loop: "{{ __partition_devices }}"
-
-
-    - name: Create VGs on LVM devices
-      community.general.lvg:
-        vg  : "{{ __vg_name }}-{{ item | split('/') | last }}"
-        pvs : "{{ item }}1"
-      loop: "{{ __partition_devices }}"
-
-
-    - name: Create LV
-      community.general.lvol:
-        vg    : "{{ __vg_name }}-{{ item | split('/') | last }}"
-        lv    : "{{ __lv_name }}-{{ item | split('/') | last }}"
-        size  : "{{ __lv_size }}"
-        force : true
-      loop: "{{ __partition_devices }}"
-
-
-    - name: Create lvol mount point
-      ansible.builtin.file:
-        path  : "{{ __lv_mount }}-{{ item | split('/') | last }}"
-        state : directory
-        mode  : "0755"
-      loop: "{{ __partition_devices }}"
-
-
-    - name: Create filesystems
-      community.general.filesystem:
-        dev    : "/dev/{{ __vg_name }}-{{ item | split('/') | last }}/{{ __lv_name }}-{{ item | split('/') | last }}"
-        fstype : "{{ __lv_fstype }}"
-      loop: "{{ __partition_devices }}"
-
-
-    - name: Mount data
-      ansible.posix.mount:
-        path   : "{{ __lv_mount }}-{{ item | split('/') | last }}"
-        src    : "/dev/{{ __vg_name }}-{{ item | split('/') | last }}/{{ __lv_name }}-{{ item | split('/') | last }}"
-        fstype : "{{ __lv_fstype }}"
-        state  : mounted
-      loop: "{{ __partition_devices }}"
-
-
 ...

tasks/create_lvm_setup.yml

@@ -0,0 +1,47 @@
+---
+- name: Debug __partition_devices
+  ansible.builtin.debug:
+    msg: "{{ item }}1 :: {{ item | split('/') | last }}"
+    verbosity: 1
+
+- name: Creating layout for {{ item }}
+  ansible.builtin.debug:
+    msg: "Setting up LVM PV/VG/LVol for {{ item }}..."
+
+- name: Create partitions on all drives
+  community.general.parted:
+    device   : "{{ item }}"
+    number   : 1
+    flags    : ['lvm']
+    state    : present
+    part_end : "{{ __part_size }}"
+
+- name: Create VGs on LVM devices
+  community.general.lvg:
+    vg  : "{{ __vg_name }}-{{ item | split('/') | last }}"
+    pvs : "{{ item }}1"
+
+- name: Create LV
+  community.general.lvol:
+    vg    : "{{ __vg_name }}-{{ item | split('/') | last }}"
+    lv    : "{{ __lv_name }}-{{ item | split('/') | last }}"
+    size  : "{{ __lv_size }}"
+    force : true
+
+- name: Create lvol mount point
+  ansible.builtin.file:
+    path  : "{{ __lv_mount }}-{{ item | split('/') | last }}"
+    state : directory
+    mode  : "0755"
+
+- name: Create filesystems
+  community.general.filesystem:
+    dev    : "/dev/{{ __vg_name }}-{{ item | split('/') | last }}/{{ __lv_name }}-{{ item | split('/') | last }}"
+    fstype : "{{ __lv_fstype }}"
+
+- name: Mount data
+  ansible.posix.mount:
+    path   : "{{ __lv_mount }}-{{ item | split('/') | last }}"
+    src    : "/dev/{{ __vg_name }}-{{ item | split('/') | last }}/{{ __lv_name }}-{{ item | split('/') | last }}"
+    fstype : "{{ __lv_fstype }}"
+    state  : mounted